feat: Add pure black theme #2824
Conversation
app/src/main/res/values/strings.xml
Outdated
| <string name="contributors_description">View the contributors of ReVanced</string> | ||
| <string name="dynamic_color">Dynamic color</string> | ||
| <string name="dynamic_color_description">Adapt colors to the wallpaper</string> | ||
| <string name="amoled_theme">AMOLED theme</string> |
There was a problem hiding this comment.
| <string name="amoled_theme">AMOLED theme</string> | |
| <string name="amoled_theme">Pitch black theme</string> |
or
| <string name="amoled_theme">AMOLED theme</string> | |
| <string name="amoled_theme">Amoled theme</string> |
There was a problem hiding this comment.
"AMOLED" is an acronym so the original styling is correct, however it's a display technology (that's now become synonymous with pitch black or pure dark theme), me personally would opt for "pitch black" like osu suggested, or "extra dark" instead.
There was a problem hiding this comment.
In the revanced patches we called it Pure black, maybe it would be correct if it had the same name everywhere.
https://github.com/ReVanced/revanced-patches/blob/96454c843b3cec4fa55f85eca54fa4714b71c5e2/patches/src/main/kotlin/app/revanced/patches/shared/layout/theme/BaseThemePatch.kt#L62
There was a problem hiding this comment.
Renamed it to "Pitch black theme" with all the code references.
There was a problem hiding this comment.
I agree with @MarcaDian here, the naming should be consistent across all ReVanced repos.
There was a problem hiding this comment.
Well in that case (of an already established decision), sure, we can name it "Pure black" for consistency sake.
There was a problem hiding this comment.
Sorry, i missed the "pure" in MarcaDian's comment and thought he was talking about "pitch black". I will do another refactor shortly.
5 participants
Adds a toggle to use pure black backgrounds for dark theme. The toggle is hidden when theme preference is set to light.
Closes #2607
This simply overrides the
backgroundandsurfacecolors of the color scheme and it is pretty much enough.Some screenshots
Toggle disabled
Toggle enabled
Toggle being hidden when theme is set to light
Homepage with the pure black theme enabled