feat: Show tooltip for unobvious elements #2637

validcube · 2025-07-05T17:48:27Z

Add TooltipWrap to well... wrap a composable component using TooltipBox.

Extended FAB aren't wrapped because they have text shown in the button.

Icon Button, Small FAB and regular FAB are wrapped because they do not have text shown.

partially fix - #2555

I can't believe this happened

validcube · 2025-07-09T09:42:23Z

I thought the contentDescription of the icon was enough for accessibility purposes but I assume there is a good reason for it.

contentDescription is for accessibility purposes (TalkBack), but Tooltip is for feature discovery purposes (let users know what this button will do before they press on it)

The pattern of wrapping an IconButton in a TooltipWrap appears a lot. Consider making a new composable to handle it.

Agree, willco on Sunday weekends.

# Conflicts: # app/src/main/java/app/revanced/manager/ui/component/ExceptionViewerDialog.kt

validcube · 2025-07-11T09:14:31Z

Done™️!

Co-authored-by: Copilot <[email protected]>

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipIconButton.kt

app/src/main/java/app/revanced/manager/ui/component/AppScaffold.kt

Co-authored-by: Ax333l <[email protected]>

Signed-off-by: Pun Butrach <[email protected]>

Copilot

Pull Request Overview

This PR adds tooltip functionality to improve accessibility for unobvious UI elements by wrapping icon buttons, floating action buttons, and small floating action buttons with tooltip components. The changes introduce new TooltipWrap composable components and their specialized variants for different button types.

Introduces new TooltipWrap component and specialized tooltip variants (TooltipIconButton, TooltipFloatingActionButton, TooltipSmallFloatingActionButton)
Replaces regular buttons with tooltip-wrapped equivalents across multiple screens to provide contextual help text
Adds haptic feedback support to tooltip components for enhanced user experience

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
TooltipWrap.kt	New base tooltip wrapper component with string and resource ID variants
TooltipIconButton.kt	IconButton wrapper with tooltip functionality
TooltipFloatingActionButton.kt	FloatingActionButton wrapper with tooltip functionality
TooltipSmallFloatingActionButton.kt	SmallFloatingActionButton wrapper with tooltip functionality
HapticSmallFloatingActionButton.kt	New haptic feedback component for small FABs
Various screen files	Updated to use tooltip-wrapped buttons instead of regular buttons

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-29T07:19:36Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipWrap.kt

+ * Wraps a composable with a tooltip.
+ *
+ * @param modifier the [Modifier] to applied to Tooltip.
+ * @param tooltip [String] text to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [String] text.

Copilot · 2025-08-29T07:19:36Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipWrap.kt

+ * Wraps a composable with a tooltip.
+ *
+ * @param modifier the [Modifier] to applied to tooltip.
+ * @param tooltip [Int] or `id` string resource to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [Int] or id.

Suggested change

* @param tooltip [Int] or `id` string resource to show in a tooltip.

* @param tooltip the string resource ID to show in a tooltip.

Copilot · 2025-08-29T07:19:37Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipIconButton.kt

+/**
+ * [IconButton] with tooltip-specific params.
+ *
+ * @param tooltip [String] text to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [String] text.

Suggested change

* @param tooltip [String] text to show in a tooltip.

* @param tooltip Text to show in a tooltip.

Copilot · 2025-08-29T07:19:37Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipIconButton.kt

+/**
+ * [IconButton] with tooltip-specific params.
+ *
+ * @param tooltip [Int] or `id` string resource to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [Int] or id.

Suggested change

* @param tooltip [Int] or `id` string resource to show in a tooltip.

* @param tooltip tooltip string resource to show in a tooltip.

Copilot · 2025-08-29T07:19:37Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipFloatingActionButton.kt

+/**
+ * [HapticFloatingActionButton] with tooltip-specific params.
+ *
+ * @param tooltip [String] text to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [String] text.

Suggested change

* @param tooltip [String] text to show in a tooltip.

* @param tooltip Text to show in a tooltip.

Copilot · 2025-08-29T07:19:38Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipFloatingActionButton.kt

+/**
+ * [HapticFloatingActionButton] with tooltip-specific params.
+ *
+ * @param tooltip [Int] or `id` string resource to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [Int] or id.

Suggested change

* @param tooltip [Int] or `id` string resource to show in a tooltip.

* @param tooltip String resource ID to show in a tooltip.

Copilot · 2025-08-29T07:19:38Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipSmallFloatingActionButton.kt

+/**
+ * [HapticSmallFloatingActionButton] with tooltip-specific params.
+ *
+ * @param tooltip [String] text to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [String] text.

Suggested change

* @param tooltip [String] text to show in a tooltip.

* @param tooltip Text to show in a tooltip.

Copilot · 2025-08-29T07:19:38Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipSmallFloatingActionButton.kt

+/**
+ * [HapticSmallFloatingActionButton] with tooltip-specific params.
+ *
+ * @param tooltip [Int] or `id` string resource to show in a tooltip.


The parameter description uses incorrect formatting. It should be tooltip instead of [Int] or id.

Suggested change

* @param tooltip [Int] or `id` string resource to show in a tooltip.

* @param tooltip Resource id of the string to show in a tooltip.

Copilot · 2025-08-29T07:19:38Z

app/src/main/java/app/revanced/manager/ui/component/patches/OptionFields.kt

                                            modifier = Modifier.draggableHandle(interactionSource = interactionSource),
-                                            onClick = {},
+                                            tooltip = stringResource(R.string.delete),
+                                            onClick = { }


Empty onClick handler should be replaced with a meaningful implementation or removed if not needed.

Suggested change

onClick = { }

onClick = {

if (!deleteMode) {

deletionTargets.add(item.key)

deleteMode = true

} else {

if (item.key in deletionTargets) {

deletionTargets.remove(item.key)

deleteMode = deletionTargets.isNotEmpty()

} else {

deletionTargets.add(item.key)

}

}

}

Copilot · 2025-08-29T07:19:39Z

app/src/main/java/app/revanced/manager/ui/screen/DashboardScreen.kt

+                        TooltipIconButton(
+                            onClick = onSettingsClick,
+                            tooltip = stringResource(R.string.settings),
+                        ) {
+                            BadgedBox(
+                                badge = {
+                                    Badge(modifier = Modifier.size(6.dp))
+                                }
+                            ) {


The settings icon shows a badge without any conditional logic. This will always display a badge even when there are no settings notifications, which is likely unintended behavior.

Suggested change

TooltipIconButton(

onClick = onSettingsClick,

tooltip = stringResource(R.string.settings),

) {

BadgedBox(

badge = {

Badge(modifier = Modifier.size(6.dp))

}

) {

// TODO: Replace with actual logic to determine if a settings notification exists

val hasSettingsNotification = false

TooltipIconButton(

onClick = onSettingsClick,

tooltip = stringResource(R.string.settings),

) {

if (hasSettingsNotification) {

BadgedBox(

badge = {

Badge(modifier = Modifier.size(6.dp))

}

) {

Icon(Icons.Outlined.Settings, stringResource(R.string.settings))

}

} else {

Axelen123 · 2025-08-29T15:02:02Z

app/src/main/java/app/revanced/manager/ui/component/PasswordField.kt

-                visible = !visible
-            }) {
+            TooltipIconButton(
+                modifier = Modifier,


It is unnecessary to add empty Modifiers, since that is already the default. There are several of these across the codebase that need to be removed as well.

Axelen123 · 2025-08-29T15:05:25Z

app/src/main/java/app/revanced/manager/ui/component/bundle/ImportBundleDialog.kt

                        },
                        supportingContent = { Text(stringResource(if (patchBundle != null) R.string.file_field_set else R.string.file_field_not_set)) },
                        trailingContent = {
+                            // TODO: Determine if this button should be [TooltipWrap]'ped


Maybe this should be adressed.

Axelen123 · 2025-08-29T15:05:55Z

app/src/main/java/app/revanced/manager/ui/component/haptics/HapticSmallFloatingActionButton.kt

+import app.revanced.manager.util.withHapticFeedback
+
+@Composable
+fun HapticSmallFloatingActionButton (


Suggested change

fun HapticSmallFloatingActionButton (

fun HapticSmallFloatingActionButton(

Axelen123 · 2025-08-29T15:08:30Z

app/src/main/java/app/revanced/manager/ui/component/patches/OptionFields.kt

+                                        TooltipIconButton(
                                            modifier = Modifier.draggableHandle(interactionSource = interactionSource),
-                                            onClick = {},
+                                            tooltip = stringResource(R.string.delete),


Using R.string.delete doesn't seem right here. This is just a drag handle.

Axelen123 · 2025-08-29T15:13:07Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipFloatingActionButton.kt

+import app.revanced.manager.ui.component.haptics.HapticFloatingActionButton
+
+/**
+ * [HapticFloatingActionButton] with tooltip-specific params.


Maybe [HapticComponent] with a tooltip or something.

Axelen123 · 2025-08-29T15:21:06Z

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipWrap.kt

+fun TooltipWrap(
+    modifier: Modifier = Modifier,
+    @StringRes tooltip: Int,
+    positionProvider: PopupPositionProvider = TooltipDefaults.rememberPlainTooltipPositionProvider(),
+    haptic: Boolean = true,
+    hapticFeedbackType: HapticFeedbackType = HapticFeedbackType.LongPress,
+    content: @Composable () -> Unit
+) {
+    val tooltipState = rememberTooltipState()
+    val localHaptic = LocalHapticFeedback.current
+
+    LaunchedEffect(tooltipState.isVisible) {
+        if (tooltipState.isVisible && haptic) {
+            localHaptic.performHapticFeedback(hapticFeedbackType)
+        }
+    }
+
+    TooltipBox(
+        modifier = modifier,
+        positionProvider = positionProvider,
+        tooltip = { PlainTooltip { Text(stringResource(tooltip)) } },
+        state = tooltipState,
+        content = content,
+    )
+}


The string resource variants seem unused, so you can get rid of them.

Axelen123 · 2025-08-29T15:24:40Z

app/src/main/java/app/revanced/manager/ui/screen/PatchesSelectorScreen.kt

    supportingContent = patch.description?.let { { Text(it) } },
    trailingContent = {
        if (patch.options?.isNotEmpty() == true) {
+            // TODO: Determine if this button should be [TooltipWrap]


Axelen123 and others added 30 commits May 20, 2025 14:00

feat(patch-selector): default patches selection (#1272)

4b178d9

chore: switch to revanced library and bump patcher (#1314)

11a383a

feat(installer): adjust step icon size and alignment

f915b54

feat(installer): adjust arrow icon size

6fed177

feat(settings): move experimental patches option to advanced

57ba3ad

fix: use correct classes to determine option type

59ddd9f

I can't believe this happened

fix: delete temporary files (#1341)

ffe5c05

feat: use revanced api for changelogs

c2c4895

feat: add patches selector bottom sheet (#1360)

e1742fd

feat: settings migration (compose) (#1309)

cadbb3f

refactor(downloaders): improve file system code (#1379)

80ff671

feat: armv7 warning

edb387e

feat: hide unfinished pages in release mode

99bfd84

fix: broken logo in about page on release builds

76e5731

chore: bump compose

977345e

chore: bump patcher

db04672

feat: add user agent (#1382)

a159246

fix: hide patch button (#1284)

88f3701

refactor: move mount code to when block

0e00b9f

feat: selected app info page (#1395)

4ad3c3f

fix: use upsert when modifying installed apps

d8d2478

fix: jvm signature clash error

5907659

fix: bundles not loading on Android 14

ac75d1d

feat(patch-selector): remove TODO about an unplanned feature

991a8cb

fix: handle exceptions when checking for bundle updates

0cf4999

fix: more android 34 fixes

464aa75

feat: add checkboxes to the downloaded apps page

1de59f4

feat: show toast when no patches are selected

da41530

docs: clarify license

3f34407

feat(bundles tab): add BackHandler

691b615

fix: Add missing header for "Updates" settings (#2642)

f7a4ae5

validcube and others added 5 commits July 9, 2025 21:01

chore: Merge branch 'compose-dev' into feat/tooltip

1510aa5

feat: Rename strings

7148ee6

feat: Tooltip{component}.kt

438fa48

Merge branch 'compose-dev' into feat/tooltip

71b0fd4

# Conflicts: # app/src/main/java/app/revanced/manager/ui/component/ExceptionViewerDialog.kt

fix: leftovers

a2caffb

validcube requested review from Axelen123 and Copilot July 11, 2025 09:14

This comment was marked as outdated.

Sign in to view

Apply suggestion from @Copilot

05afc6b

Co-authored-by: Copilot <[email protected]>

Axelen123 requested changes Jul 12, 2025

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/tooltip/TooltipIconButton.kt Outdated Show resolved Hide resolved

app/src/main/java/app/revanced/manager/ui/component/AppScaffold.kt Outdated Show resolved Hide resolved

validcube and others added 6 commits July 14, 2025 15:35

fix: Transparent status on fullscreen dialog (#2654)

b51d1ee

feat: allow bundles to use classes from other bundles (#1951)

789f9ec

fix: Show selection warning also on patch option (#2643)

486ed59

feat: Rename "Patch bundle" to "Patches" (#2541)

47e4ed8

Co-authored-by: Ax333l <[email protected]>

chore: remove unused dependency

244674a

fix: remove unused function preventing compilation

fc96137

validcube mentioned this pull request Aug 25, 2025

fix: Use ReVanced background colour for splash screen #2635

Closed

validcube added 3 commits August 27, 2025 22:52

refactor: Remove redundant modifier parameter from Tooltip components

9b53ffd

Merge branch 'compose-dev' into feat/tooltip

1dcd3d8

Signed-off-by: Pun Butrach <[email protected]>

fix: commas

239b035

validcube requested review from Axelen123 and Copilot August 27, 2025 16:04

Copilot AI reviewed Aug 29, 2025

View reviewed changes

Axelen123 requested changes Aug 29, 2025

View reviewed changes

oSumAtrIX force-pushed the compose-dev branch from b1f2e5c to 775c2d5 Compare October 1, 2025 19:54

Ushie removed the ReVanced Manager Compose label Oct 3, 2025

Ushie changed the base branch from compose-dev to dev October 3, 2025 13:15

	* @param tooltip [Int] or `id` string resource to show in a tooltip.
	* @param tooltip the string resource ID to show in a tooltip.

	* @param tooltip [String] text to show in a tooltip.
	* @param tooltip Text to show in a tooltip.

	* @param tooltip [Int] or `id` string resource to show in a tooltip.
	* @param tooltip tooltip string resource to show in a tooltip.

	* @param tooltip [Int] or `id` string resource to show in a tooltip.
	* @param tooltip String resource ID to show in a tooltip.

	* @param tooltip [Int] or `id` string resource to show in a tooltip.
	* @param tooltip Resource id of the string to show in a tooltip.

-                                            onClick = { }
+                                            onClick = {
+                                                if (!deleteMode) {
+                                                    deletionTargets.add(item.key)
+                                                    deleteMode = true
+                                                } else {
+                                                    if (item.key in deletionTargets) {
+                                                        deletionTargets.remove(item.key)
+                                                        deleteMode = deletionTargets.isNotEmpty()
+                                                    } else {
+                                                        deletionTargets.add(item.key)
+                                                    }
+                                                }
+                                            }

	fun HapticSmallFloatingActionButton (
	fun HapticSmallFloatingActionButton(

Uh oh!

feat: Show tooltip for unobvious elements #2637

Are you sure you want to change the base?

feat: Show tooltip for unobvious elements #2637

Uh oh!

Conversation

validcube commented Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

validcube commented Jul 9, 2025

Uh oh!

validcube commented Jul 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Axelen123 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

validcube commented Jul 5, 2025 •

edited

Loading