Skip to content

utils.c: include <signal.h> for siginfo_t #7517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 10 commits into from
Jan 12, 2026
+8 −2
Merged

utils.c: include <signal.h> for siginfo_t #7517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2da9fd8
utils.c: include <signal.h> for siginfo_t
aitap Dec 25, 2025
513b017
NEWS entry
aitap Dec 25, 2025
baaf8ca
Amend NEWS
aitap Dec 25, 2025
db69eae
more robustly define _POSIX_C_SOURCE (h/t Hugh)
MichaelChirico Dec 31, 2025
327e2a5
tidy up NEWS
MichaelChirico Dec 31, 2025
970c0bf
Merge branch 'master' into posix_siginfo_t
MichaelChirico Dec 31, 2025
a5a2644
-D_POSIX_C_SOURCE=200809L in gitlab CI job for regression test
MichaelChirico Jan 1, 2026
08771f1
Merge branch 'master' into posix_siginfo_t
MichaelChirico Jan 8, 2026
7e3fbc9
Merge branch 'master' into posix_siginfo_t
MichaelChirico Jan 12, 2026
3cc6658
revert gitlab-ci change
MichaelChirico Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@

6. `rowwiseDT()` now provides a helpful error message when a complex object that is not a list (e.g., a function) is provided as a cell value, instructing the user to wrap it in `list()`, [#7219](https://github.com/Rdatatable/data.table/issues/7219). Thanks @kylebutts for the report and @venom1204 for the fix.

7. Fixed compilation failure like "error: unknown type name 'siginfo_t'" in v1.18.0 in some strict environments, e.g., FreeBSD, where the header file declaring the POSIX function `waitid` does not transitively include the header file defining the `siginfo_t` type, [#7516](https://github.com/rdatatable/data.table/issues/7516). Thanks to @jszhao for the report and @aitap for the fix.
Copy link
Member Author

@aitap aitap Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: the underscore in "error: unknown type name 'siginfo_t'" is an unpaired emphasis mark. This doesn't confuse Pandoc or commonmark, but makes the Vim syntax highlighter unhappy. Some variation on "error: unknown type name 'siginfo\_t'" or "error: unknown type name `siginfo_t`" would be slightly better.

Copy link
Member

@MichaelChirico MichaelChirico Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer `error: unknown type name 'siginfo_t'` to keep it human-readable too


### Notes

1. {data.table} now depends on R 3.5.0 (2018).
Expand Down
8 changes: 6 additions & 2 deletions src/utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#ifndef _WIN32
# define _POSIX_C_SOURCE 200809L // required for POSIX (not standard C) features in is_direct_child e.g. 'siginfo_t'
# include <sys/wait.h>
# if !defined(_POSIX_C_SOURCE) || _POSIX_C_SOURCE < 200809L
# undef _POSIX_C_SOURCE
# define _POSIX_C_SOURCE 200809L // required for POSIX (not standard C) features in is_direct_child e.g. 'siginfo_t'
# endif
# include <signal.h> // siginfo_t
# include <sys/wait.h> // waitid
#endif

#include "data.table.h"
Expand Down
Loading