-
Notifications
You must be signed in to change notification settings - Fork 1k
deactivate froll tests #7429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
deactivate froll tests #7429
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7429 +/- ##
==========================================
- Coverage 99.13% 99.07% -0.07%
==========================================
Files 85 85
Lines 16618 16609 -9
==========================================
- Hits 16474 16455 -19
- Misses 144 154 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Why disable the whole test script. I think that all non-batch tests should finish under 10s and they are very useful, as show by recently detected breaking changes detected by revdeps check. |
jangorecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as request change ls because we want to have at least the basic tests run each time. Only batch testing are the issue here. So either a branching them based on env car, or interactive(), or moving to another test script seems much better way to address the issue.
jangorecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for enabling tests back.
As for env bars, we, and base R always uses capital case with underscores. Any good reason to use camel case instead?
Nah that was just shamelessly copied from Dirk. Should we maybe run batch tests only in Gitlab and RMD-check-occasional? |
Generated via commit d6c1411 Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
I would run them as well for interactive session. Maybe we can detect interactive inside |
We could but if you run them interactively you gonna type |

Towards #6400
Current
frollchecking times would not pass CRAN.Change is structured in such a way that releases do not run
froll.Rraw. One can still force the execution by settingSys.setenv("RunAllDataTableTests"="yes")What still needs to be discussed is whether we want to disable main test suite on CRAN...