Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more explicit return()s thanks to lintr update #6830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

{lintr} removed a lot of false negatives in return_linter():

r-lib/lintr#2779

Basically any function with any argument with defaults could be affected.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.64%. Comparing base (f78044e) to head (331f5db).

Files with missing lines Patch % Lines
R/setkey.R 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6830      +/-   ##
==========================================
- Coverage   98.64%   98.64%   -0.01%     
==========================================
  Files          79       79              
  Lines       14642    14638       -4     
==========================================
- Hits        14444    14439       -5     
- Misses        198      199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Comparison Plot

Generated via commit 331f5db

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 39 seconds
Installing different package versions 8 minutes and 9 seconds
Running and plotting the test cases 2 minutes and 20 seconds

Copy link
Member Author

MichaelChirico commented Feb 23, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant