-
Notifications
You must be signed in to change notification settings - Fork 10
build: update design system to v2.7.0 #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 2.0.0 uses vite and packages core, so that dep can removed. - Link to core style does however need to be added to the app, following the update guide for the design system. - TextEncoder/TextDecoder was not set up in jest and this was causing some design system component to fail tests.
- No buttons using href prop so no changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the design system packages from version 1.6.0 to 2.6.2, consolidating two separate packages (design-system-core and design-system-react) into a single design-system-react package that includes the core functionality.
Key changes:
- Upgraded
@raspberrypifoundation/design-system-reactfrom 1.6.0 to 2.6.2 and removed the separatedesign-system-coredependency - Updated styling imports to use the consolidated package structure
- Added Material Symbols font to the web component preview page
- Added TextEncoder/TextDecoder polyfills for Jest environment
- Fixed minor JavaScript style inconsistencies (missing semicolons)
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed separate design-system-core dependency and pinned design-system-react to version 2.6.2 |
| yarn.lock | Updated lockfile with new package versions and dependency changes for design system packages |
| src/assets/stylesheets/ExternalStyles.scss | Updated SCSS imports to use consolidated design-system-react package path |
| src/web-component.html | Added Material Symbols font link and fixed missing semicolons for consistency |
| src/utils/setupTests.js | Added TextEncoder/TextDecoder polyfills required by new design system version |
| CHANGELOG.md | Documented the design system upgrade and Material Symbols font addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ates of the Design System React Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Also use `^` in package.json and update lock file accordingly
|
LGTM |
Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/968
Summary
Update to the latest design system to take advantage of new components and features.
What's been done?
Screenshots
Issues to be solved in another PR
button) rather than overriding custom properties - which would normally avoid most breaking changes. Largely "core breaking component changes" only affect upstream packages (react/rails).Suggested tasks: