Skip to content

Remove unused API endpoints and unused stubbing of Profile API #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions app/controllers/api/school_owners_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,5 @@ def index
render json: { error: result[:error] }, status: :unprocessable_entity
end
end

def create
result = SchoolOwner::Invite.call(school: @school, school_owner_params:, token: current_user.token)

if result.success?
head :created
else
render json: { error: result[:error] }, status: :unprocessable_entity
end
end

def destroy
result = SchoolOwner::Remove.call(school: @school, owner_id: params[:id], token: current_user.token)

if result.success?
head :no_content
else
render json: { error: result[:error] }, status: :unprocessable_entity
end
end

private

def school_owner_params
params.require(:school_owner).permit(:email_address)
end
end
end
10 changes: 0 additions & 10 deletions app/controllers/api/school_teachers_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,6 @@ def create
end
end

def destroy
result = SchoolTeacher::Remove.call(school: @school, teacher_id: params[:id], token: current_user.token)

if result.success?
head :no_content
else
render json: { error: result[:error] }, status: :unprocessable_entity
end
end

private

def school_teacher_params
Expand Down
4 changes: 2 additions & 2 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
end
end

resources :owners, only: %i[index create destroy], controller: 'school_owners'
resources :teachers, only: %i[index create destroy], controller: 'school_teachers'
resources :owners, only: %i[index], controller: 'school_owners'
resources :teachers, only: %i[index create], controller: 'school_teachers'
resources :students, only: %i[index create update destroy], controller: 'school_students' do
post :batch, on: :collection, to: 'school_students#create_batch'
end
Expand Down
28 changes: 0 additions & 28 deletions lib/concepts/school_owner/invite.rb

This file was deleted.

23 changes: 0 additions & 23 deletions lib/concepts/school_owner/remove.rb

This file was deleted.

24 changes: 0 additions & 24 deletions lib/concepts/school_teacher/remove.rb

This file was deleted.

16 changes: 0 additions & 16 deletions lib/profile_api_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,6 @@ def create_school(token:, id:, code:)
School.new(**response.body)
end

def list_school_owners(*)
{}
end

def invite_school_owner(*)
{}
end

def remove_school_owner(*)
{}
end

def remove_school_teacher(*)
{}
end

def school_student(token:, school_id:, student_id:)
response = connection(token).get("/api/v1/schools/#{school_id}/students/#{student_id}")

Expand Down
69 changes: 0 additions & 69 deletions spec/concepts/school_owner/invite_spec.rb

This file was deleted.

1 change: 0 additions & 1 deletion spec/concepts/school_owner/list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
let(:owner_ids) { [owner.id] }

before do
stub_profile_api_list_school_owners(user_id: owner.id)
stub_user_info_api_for(owner)
end

Expand Down
48 changes: 0 additions & 48 deletions spec/concepts/school_owner/remove_spec.rb

This file was deleted.

48 changes: 0 additions & 48 deletions spec/concepts/school_teacher/remove_spec.rb

This file was deleted.

Loading