Use Identifiable#current_user in API controllers #566
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these were using the `@current_user` instance variable. However, this was working somewhat by accident, because `ApiController#authorize_user` (called by a `before_action`) was calling `Identifiable#current_user` and thus setting `@current_user`. I think it's safer, more idiomatic and less confusing to have an explicit call to `Identifiable#current_user`.
raspberrypiherokubot
temporarily deployed
to
editor-api-p-fix-curren-q6rjdb
sebjacobs
approved these changes
Jul 8, 2025
|
@adrian-rpf This addresses one of the issues I mentioned when we chatted the other day. I'd welcome your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these were using the
@current_userinstance variable. However, this was working somewhat by accident, becauseApiController#authorize_user(called by abefore_action) was callingIdentifiable#current_userand thus setting@current_user.I think it's safer, more idiomatic and less confusing to have an explicit call to the memo-ized
Identifiable#current_user. Especially as that's what we're already using in all the other controllers and even in other places in these controllers!