Repository navigation
Conversation
… a drag updateSlider_() set the range input's value attribute, which browsers ignore once the user has moved the slider. Set the value property instead so the knob follows values typed into the text editor.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10330
Proposed Changes
updateSlider_() in field_slider.ts now sets the range input’s value property instead of its value attribute. One line, plus a comment.
Reason for Changes
After you drag the slider knob once, it stops following the inline text editor. That’s because browsers only read the value attribute as the initial value; once the user has interacted with a range input, changing the attribute does nothing, but setting the property moves the knob. Happens in v11 and v12.
Test Coverage
Added a unit test, “Slider follows the text editor after being dragged”: open the editor, drag to 20, type 70 in the text field, check the slider shows 70. Runs under jsdom with small stubs for SVGElement, FocusEvent and requestAnimationFrame.
Video of the fixed playground: https://github.com/user-attachments/assets/d7fbcf5d-3891-43a0-80ab-0b57a437329d
Documentation
None, no API change.
Additional Information
AI use: The fix and the test were written with Claude Code. The video is an automated run of this branch recorded by User Stories Bot. I reviewed the diff and wrote this description.