Skip to content

fix: Update JSDoc types in plus-minus procedure blocks #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 1 commit into from
Jan 21, 2026
Merged

fix: Update JSDoc types in plus-minus procedure blocks #2673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/block-plus-minus/src/procedures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ const procedureDefMutator = {
/**
* Returns true if the given argDatum is associated with this field, or has
* a different caseless name than the argDatum associated with this field.
* @param {{model: Blockly.VariableModel, argId:string}} argDatum The
* @param {{model: Blockly.IVariableModel, argId:string}} argDatum The
* argDatum we want to make sure does not conflict with the argDatum
* associated with this field.
* @returns {boolean} True if the given datum does not conflict with the
Expand Down Expand Up @@ -574,7 +574,7 @@ const procedureDefHelper = function () {
* An array of objects containing data about the args belonging to the
* procedure definition.
* @type {!Array<{
* model:Blockly.VariableModel,
* model:Blockly.IVariableModel,
* argId: string
* }>}
* @private
Expand Down Expand Up @@ -624,7 +624,7 @@ const procedureVars = function () {

/**
* Return all variables referenced by this block.
* @returns {!Array.<!Blockly.VariableModel>} List of variable models.
* @returns {!Array.<!Blockly.IVariableModel>} List of variable models.
* @this {Blockly.Block}
*/
getVarModels: function () {
Expand Down Expand Up @@ -659,7 +659,7 @@ const procedureVars = function () {
/**
* Notification that a variable is renaming but keeping the same ID. If the
* variable is in use on this block, rerender to show the new name.
* @param {!Blockly.VariableModel} variable The variable being renamed.
* @param {!Blockly.IVariableModel} variable The variable being renamed.
* @package
* @override
* @this {Blockly.Block}
Expand Down
Loading