Allow full stops in route parameters #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the suggested fix in https://github.com/dannyvankooten/AltoRouter/issues/221#issuecomment-424599922 in order to allow the router to parse param values with dots.
We will need to consider the implications of this, as the comment mentions that it ignores full stops so that you can ignore file extensions in URLs. This MR causes some behaviour changes:
Previously
/route/{id}withroute/file.txtwould not match at all.Now
/route/{id}withroute/file.txtwould match, andidwould be mapped tofile.txt.