Skip to content

Polkadot v1.24.0 stable2606#2948

Open
UnArbosSix wants to merge 19 commits into
mainfrom
polkadot-v1.24.0
Open

Polkadot v1.24.0 stable2606#2948
UnArbosSix wants to merge 19 commits into
mainfrom
polkadot-v1.24.0

Conversation

@UnArbosSix

@UnArbosSix UnArbosSix commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Upgrade Subtensor from the previous RaoFoundation Polkadot SDK revision to the Polkadot v1.24.0 stable2606 revision, keeping the node, runtime, pallets, SDK, and vendored Frontier integration compatible with the updated APIs.

Changes

  • Updated workspace Polkadot SDK dependencies and regenerated the root and Frontier lockfiles.
  • Updated the Rust toolchain for stable2606.
  • Adapted Aura/BABE consensus import and verifier construction to the new SDK interfaces.
  • Updated runtime APIs for lazy blocks and the revised session-key generation interface.
  • Adapted transaction-fee handling to the new credit API.
  • Updated shielded-extrinsic inspection to use ExtrinsicCall while retaining signature validation.
  • Migrated hashing and debug derives to their current SDK locations/names.
  • Applied compatibility updates across pallets, precompiles, tests, and the Rust SDK.
  • Removed the obsolete 60,000-page executor heap override because stable2606 interprets it as additional pages.

Files of interest

  • Cargo.toml, Cargo.lock, rust-toolchain.toml
  • node/src/consensus/
  • node/src/command.rs
  • runtime/src/lib.rs
  • pallets/shield/src/lib.rs
  • pallets/transaction-fee/src/lib.rs
  • vendor/frontier/

Behavioral impact

This is primarily an SDK compatibility upgrade. Consensus initialization and block import use the stable2606 APIs, runtime execution accepts lazy blocks, and nodes retain the SDK’s default heap strategy. No intentional change to Subtensor economic policy or extrinsic semantics is introduced.

Runtime and migration implications

The runtime code and dependencies change, so the runtime spec_version is bumped from 432 to 433. No storage migration is introduced.

Validation

The complete repository CI suite, including formatting, compilation, pallet/runtime tests, and runtime build checks, should pass before merge.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview, Comment Jul 24, 2026 1:16am

Request Review

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

eco-tests changed — indexer review required

This PR modifies files under eco-tests/. and may affect downstream indexing.
cc @evgeny-s — please review manually

Changed files
  • eco-tests/Cargo.toml
  • eco-tests/src/mock.rs

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: VULNERABLE

VERY HIGH scrutiny: 22-day-old account with 0 public repos, moderated by repository write access, matching corporate commit identity, and no Gittensor association; polkadot-v1.24.0 → main.

The latest merge from main introduced a runtime-version collision that was not present in the prior review. The dependency, consensus, authorized-transaction, shield, fee-credit, generated-weight, and CI changes otherwise showed no concrete malicious behavior.

Findings

Sev File Finding
HIGH runtime/src/lib.rs (VERSION.spec_version) Runtime changes reuse deployed spec version 438 (off-diff)

Other findings

  • [HIGH] Runtime changes reuse deployed spec version 438 (runtime/src/lib.rs (VERSION.spec_version)) — Both the PR and current main declare spec_version: 438, but this PR changes runtime code and its Polkadot SDK dependencies. Reusing the deployed runtime version can prevent clients and release tooling from recognizing the upgrade and invalidates version-keyed runtime caches. Increment spec_version beyond 438 before merging.

Conclusion

The PR changes runtime behavior while retaining the deployed spec_version 438, so it is unsafe to merge until the version is incremented.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

UNKNOWN Gittensor association; author has repository write access but a very new account, so this broad SDK upgrade received heightened scrutiny.

The stable2606 compatibility changes remain coherent across consensus wiring, host functions, lazy-block runtime APIs, transaction-fee credits, shielded-extrinsic inspection, and vendored Frontier. The runtime spec_version is bumped from 437 to 438, and git diff --check passes.

Description discrepancy: the PR body says spec_version changes from 432 to 433; it should say 437 to 438.

The overlapping PRs are unrelated or dependent work despite sharing files. No auto-fix was needed.

Findings

No findings.

Conclusion

No substantive domain issue was identified. Given the dependency upgrade’s breadth, the complete repository CI suite should pass before merge.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@UnArbosSix UnArbosSix added run-benchmarks run benchmarks and removed run-benchmarks run benchmarks labels Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: VULNERABLE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmarks run benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant