Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the design pattern of BlockSolver? #319

Open
jingedawang opened this issue Nov 1, 2018 · 1 comment
Open

What's the design pattern of BlockSolver? #319

jingedawang opened this issue Nov 1, 2018 · 1 comment
Labels

Comments

@jingedawang
Copy link

When I was using BlockSolver, I was confused of the design of this class. I found that I am not able to decide which vertex to marginalize. It seems only landmarks can be marginalized, also, they must be marginalized. It is really a strict restrict. Maybe it can be better designed?

For example, this line block_solver.hpp#L118 distinguishes poses and landmarks by marginalization. Is it a proper way?

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant