Skip to content

Additional value mapping (Hanami 2 integration) #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Additional value mapping (Hanami 2 integration) #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
539fc3b
Remove dependency from activesupport.
Apr 5, 2022
2806d8a
Add transformation for values type of hash
Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion contrib/ruby_event_store-rom/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@ gem "mysql2", ">= 0.5.3"
gem "pg", ">= 1.2.2"
gem "ruby_event_store", path: "../../ruby_event_store"
gem "sqlite3", "1.4.2"
gem "activesupport"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile is purely for test. We're not using bundler groups at all anywhere in the RES codebase.

You can have a look on ROM dependencies at:

rails_event_store/contrib/ruby_event_store-rom/ruby_event_store-rom.gemspec

Lines 29 to 36 in be89cf8

spec.add_dependency "dry-container", ">= 0.6"
spec.add_dependency "dry-initializer", ">= 3.0"
spec.add_dependency "dry-types", ">= 1.0"
spec.add_dependency "rom-changeset", ">= 5.0"
spec.add_dependency "rom-repository", ">= 5.0"
spec.add_dependency "rom-sql", ">= 3.0"
spec.add_dependency "sequel", ">= 5.11.0"
spec.add_dependency "ruby_event_store", ">= 2.0.0", "< 3.0.0"


group :test do
gem "activesupport"
end
2 changes: 2 additions & 0 deletions contrib/ruby_event_store-rom/lib/ruby_event_store/rom/changesets/create_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class CreateEvents < ::ROM::Changeset::Create
rename_keys timestamp: :created_at
map_value :created_at, ->(time) { Time.iso8601(time).localtime }
map_value :valid_at, ->(time) { Time.iso8601(time).localtime }
map_value :data, ->(value) { value.class.name == "Hash" ? value.to_json : value }
map_value :metadata, ->(value) { value.class.name == "Hash" ? value.to_json : value }
accept_keys %i[event_id data metadata event_type created_at valid_at]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth adding a test recreating the situation you've encountered?

end

Expand Down