Skip to content

Conversation

climbus
Copy link
Contributor

@climbus climbus commented Feb 23, 2022

When posted wrong vat code: NameError (uninitialized constant Invoicing::Product::VatRateNotApplicable)
But still not working because of https://github.com/RailsEventStore/ecommerce/blob/master/rails_application/app/controllers/products_controller.rb#L45 and exception: [Infra::Types::VatRate.new] :code is missing in Hash input

;)

When posted wrong vat code: NameError (uninitialized constant Invoicing::Product::VatRateNotApplicable)
But still not working because of https://github.com/RailsEventStore/ecommerce/blob/master/rails_application/app/controllers/products_controller.rb#L45 and exception: [Infra::Types::VatRate.new] :code is missing in Hash input

;)
@andrzejkrzywda andrzejkrzywda merged commit ed3c1ea into RailsEventStore:master Feb 23, 2022
@andrzejkrzywda
Copy link
Contributor

thanks!

what would be the best test to cover this?

@climbus
Copy link
Contributor Author

climbus commented Feb 24, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants