Skip to content

Adc implementation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 26, 2020
Merged

Adc implementation #23

merged 18 commits into from
Jul 26, 2020

Conversation

lperlaki
Copy link
Contributor

@lperlaki lperlaki commented Jul 25, 2020 •
edited by Rahix
Loading

My attempt of implementing ADC currently only for the Arduino Uno

Needs avr-device/29

Fixes #11.

@Rahix Rahix added the hal-impl label Jul 25, 2020
Rahix
Rahix requested changes Jul 25, 2020
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I left a few comments in the diff. Additionally, it would be nice if you could add a small example to the arduino-uno crate which demonstrates the use of the ADC.

@lperlaki
Copy link
Contributor Author

@Rahix I am not to sure about my into_analog Pin implementation if you have some input on that

Rahix
Rahix reviewed Jul 25, 2020
View reviewed changes
Rahix
Rahix reviewed Jul 25, 2020
View reviewed changes
Rahix
Rahix reviewed Jul 26, 2020
View reviewed changes
@Rahix Rahix self-requested a review July 26, 2020 08:10
Rahix
Rahix approved these changes Jul 26, 2020
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an ATmega328P at hand, so I'll have to trust that you have tested this. Apart from, everything looks good!

@lperlaki
Copy link
Contributor Author

I did some tests similar to the uno-adc example on an Arduino Uno board
Would also like to implement adc for the atmetga32u4 but I don't currently have a board with that chip.

@Rahix
Copy link
Owner

Rahix commented Jul 26, 2020

Would also like to implement adc for the atmetga32u4 but I don't currently have a board with that chip.

I can take care of that, should not be difficult ontop of this PR :)

@Rahix Rahix merged commit 55b8192 into Rahix:master Jul 26, 2020
@lperlaki lperlaki deleted the adc branch October 6, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADC Implementation
2 participants
@lperlaki @Rahix