Devcontainer support #161
Devcontainer support #161
Conversation
code. minFormatted and maxFormatted add a bit of unnecessary overhead for a consumer to do any logic or tracking of the min/max range (eg, for telemetry).
jdmarshall
force-pushed
the
devcontainer
branch
2 times, most recently
from
39457b3 to
d65a553
Compare
jdmarshall
force-pushed
the
devcontainer
branch
from
d65a553 to
1f6f8c4
Compare
Dockerfile
Outdated
| @@ -0,0 +1,3 @@ | |||
| FROM node:24.4-bookworm-slim | |||
There was a problem hiding this comment.
Oh. Huh. I think the first page I found with the releases and LTS schedule made it look like bookworm was the current LTS version. Found another chart that’s clearer.
How do you feel about alpine?
There was a problem hiding this comment.
Alpine is an unofficial build too. See: nodejs/docker-node#2363
but I guess that's ok for this project.
Also 24.6 is the last node version that honors the nodejs CLI flags.
| @@ -0,0 +1,3 @@ | |||
| FROM node:24.6-trixie-slim | |||
There was a problem hiding this comment.
Can we avoid fixing a semver-minor version? What about node:24-alpine only?
There was a problem hiding this comment.
Not with the outstanding issue with commandline flags and tests.
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
You should rebase and keep only the devcontainer.json changes. Feel free to land it once you remove the two unrelated commit.
2 participants
While npmjs.org is trying to take important steps to reduce supply chain attacks, working with, or indeed on, other people's OSS projects is still a bit fraught at the moment.
While dev containers are really meant for more elaborate workflows, a barebones implementation seems to be pretty okay for isolating
npm installfrom having access to things it should not have access to.