Skip to content

Issue #115 - Threading issue within localization resolver when cachin… #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Issue #115 - Threading issue within localization resolver when cachin… #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions Sdl.Web.Tridion/Resolvers/Localization/GraphQLLocalizationResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,23 +67,25 @@ public override Localization ResolveLocalization(Uri url)
}

string localizationId = mapping.PublicationId.ToString();
if (!KnownLocalizations.TryGetValue(localizationId, out result))
lock (KnownLocalizations)
{
result = new Localization
if (!KnownLocalizations.TryGetValue(localizationId, out result))
{
Id = localizationId,
Path = mapping.Path
};
KnownLocalizations.Add(localizationId, result);
}
else
{
// we fill in the path regardless as it may of been
// a partially created localization.
result.Path = mapping.Path;
result = new Localization
{
Id = localizationId,
Path = mapping.Path
};
KnownLocalizations.Add(localizationId, result);
}
else
{
// we fill in the path regardless as it may of been
// a partially created localization.
result.Path = mapping.Path;
}
}


result.EnsureInitialized();

Log.Trace($"Localization for url '{url}' initialized and reports to be for Publication Id: {result.PublicationId()}, Path: {result.Path}");
Expand Down