remove unnecessary mask of batch infer #2034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个你测过tensor值是否一样吗 GPT-SoVITS/GPT_SoVITS/AR/models/t2s_model.py Line 150 in c8c5d6a 就是在这一行前，是否为None2个结果作差求L1看是否为0 |
从整体比较整个tensor的话是不一样的，不一样的部分对应于被padding mask给mask掉那些的position；具体来说，当前主线代码会去手动mask这些位置，但实际上没必要，因为在attention mask作用下这些位置的结果在后续的操作中是直接被忽视的、不会影响到token预测，即最终预测出的token是完全一样的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attention mask可以认为已经”包含了“padding mask，所以padding mask不会影响最终计算结果