Skip to content

[xuantie/bsp] 修正生成玄铁CDK工程脚本并适配E906 BSP #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025

Conversation

Yaochenger
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  • 修正xuantie bsp生成SDK工程的脚本,并适配E906 BSP

你的解决方案是什么 (what is your solution)

  • 修正脚本中对汇编文件的处理并给E906 BSP添加CDK工程模板

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Xuantie BSP CDK project generation script and adds support for the E906 BSP. The changes address assembly file handling in the script and provide CDK project templates for the E906 platform.

  • Fixed assembly file define handling in the CDK project generation script
  • Added CDK project templates and configuration files for E906 BSP
  • Added preprocessor defines for E906 board configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/targets/cdk.py Fixed assembly defines handling and encoding issue in CDK project generation
bsp/xuantie/smartl/e906/utilities/gdb.init Added GDB initialization script for E906 debugging
bsp/xuantie/smartl/e906/template.cdkws Added CDK workspace template for E906 project
bsp/xuantie/smartl/e906/template.cdkproj Added CDK project template with E906-specific configuration
bsp/xuantie/smartl/e906/board/SConscript Added preprocessor defines for E906 board configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Rbb666 Rbb666 merged commit f4e4188 into RT-Thread:master Aug 19, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants