proposal & refactor: reuse list_find* related logic by adding rt_object_for_each_safe
#10605
+514
−897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject_for_each_safe` Hello, I found may duplicate logic which is related to `list_find*`. I'd like to do something to simplify them. At first, I found the `rt_object_for_each` and tried to use it. But after carefully checking, I found the logic is a little different from the previous version. The most important one is that the different logic is running without lock, which is different with `rt_object_for_each`. So I add `rt_object_for_each_safe`, It will use the same logic with `list_find*` and call the iterator without locked. Signed-off-by: a1012112796 <[email protected]>
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
🏷️ Tag: kernelReviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837 Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-08-13 22:26 CST)
📝 Review Instructions
|
github-actions
bot
added
Kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
添加
rt_object_for_each_safe函数，以简化和统一 cmd.c 以及其他位置中出现的list_find*相关的逻辑函数，同时也便于应用层在需要对对象遍历处理时使用。
与
rt_object_for_each的差异是，实现逻辑与list_find*一致，回调调用的位置不锁调度器。你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up