[component][net][at] at_client增加deInit接口 #10598

Ryan-CW-Code · 2025-08-11T07:29:01Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

V2版本的串口，已在at_socket没有使用deinit测试3天，ppp拨号中每隔3分钟deinit一次测试4天。
V1版本的串口，在at_socket测试一个小时。
已知待解决：at_device软件包中直接访问at_client的lock变量需要修改一下，合并后就准备给at_device提PR

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

github-actions · 2025-08-11T07:29:13Z

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)

components/net/at/include/at.h
components/net/at/src/at_client.c

🏷️ Tag: components_net_at

Reviewers: Ryan-CW-Code lizhen9880

Changed Files (Click to expand)

components/net/at/include/at.h
components/net/at/src/at_client.c

📊 Current Review Status (Last Updated: 2025-08-18 22:58 CST)

⌛ Maihuanyi Pending Review
⌛ Ryan-CW-Code Pending Review
⌛ lizhen9880 Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Ryan-CW-Code · 2025-08-11T07:43:32Z

上面实现中，at_client_rx_ind使用了rt_device的user_data，大佬们可以给点意见看合适不合适。
不合适的话就改回轮询方式

更新: 已修改为轮询方式

Ryan-CW-Code · 2025-08-11T09:12:07Z

CI错误都是at_device软件包的报错，合并此PR后会对at_device提PR

Ryan-CW-Code · 2025-08-11T12:22:26Z

@Rbb666
AI审查真的很有用，建议把coderabbitai也加上，开源项目免费

Rbb666 · 2025-08-11T12:24:27Z

@Rbb666 AI审查真的很有用，建议把coderabbitai也加上，开源项目免费

我研究下

Rbb666 · 2025-08-12T04:38:19Z

components/net/at/src/at_client.c

@@ -41,7 +47,7 @@ extern rt_size_t at_vprintfln(rt_device_t device, char *send_buf, rt_size_t buf_
 extern rt_size_t at_vprintf(rt_device_t device, char *send_buf, rt_size_t buf_size, const char *format, va_list args);
 extern rt_size_t at_vprintfcr(rt_device_t device, char *send_buf, rt_size_t buf_size, const char *format, va_list args);
 extern rt_size_t at_vprintflf(rt_device_t device, char *send_buf, rt_size_t buf_size, const char *format, va_list args);
-extern void at_print_raw_cmd(const char *type, const char *cmd, rt_size_t size);
+extern void      at_print_raw_cmd(const char *type, const char *cmd, rt_size_t size);


代码需要用工具格式化下

代码需要用工具格式化下

用clang-format格式化的，使用的 https://github.com/RT-Thread/rt-thread/blob/master/.clang-format 配置文件

Rbb666 · 2025-08-12T04:40:06Z

components/net/at/src/at_client.c

+                        return -RT_EFULL;
+                    }
+
+                    // Since the buffer state is uncertain, we proactively clear it; the overhead is negligible.


注释风格请统一使用 /**/

Rbb666 · 2025-08-12T04:40:30Z

components/net/at/src/at_client.c

            }
            else
            {
-/*                log_d("unrecognized line: %.*s", client->recv_line_len, client->recv_line_buf);*/
+                // rt_kprintf("unrecognized line: %.*s", client->recv_line_len, client->recv_line_buf);


无关的代码请删除

Ryan-CW-Code · 2025-08-14T03:35:49Z

@Rbb666 @lizhen9880 @Maihuanyi 麻烦再审查一遍吧

Copilot

Pull Request Overview

This PR adds a deInit interface to the AT client component for proper cleanup and resource management. The implementation replaces the static client table with a dynamic linked list and switches from semaphores to events for better synchronization control.

Key changes:

Added at_client_deInit() function for graceful client cleanup
Replaced static client array with dynamic linked list for better memory management
Switched from semaphores to RT-Thread events for synchronization
Changed mutex/semaphore pointers to embedded objects in client struct

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
components/net/at/src/at_client.c	Core implementation of deInit functionality, client management refactoring, and synchronization mechanism changes
components/net/at/include/at.h	Header updates for new deInit function declaration and client struct modifications

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-16T04:08:38Z

components/net/at/src/at_client.c

        resp->line_counts = 0;
    }

    client->resp = resp;
-    rt_sem_control(client->resp_notice, RT_IPC_CMD_RESET, RT_NULL);
+    rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);


This rt_event_recv call with timeout 0 appears to be used for clearing events, but the return value is not checked. This should likely use rt_event_control with RT_IPC_CMD_RESET for clearing events, or the return value should be handled.

Suggested change

rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);

if (rt_event_control(&client->event, RT_IPC_CMD_RESET, RT_NULL) != RT_EOK)

{

LOG_E("Failed to clear client event before sending command!");

rt_mutex_release(&client->lock);

return -RT_ERROR;

}

Copilot · 2025-08-16T04:08:38Z

components/net/at/src/at_client.c

        resp->line_counts = 0;
    }

    client->resp = resp;
-    rt_sem_control(client->resp_notice, RT_IPC_CMD_RESET, RT_NULL);
+    rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);


This rt_event_recv call with timeout 0 appears to be used for clearing events, but the return value is not checked. This should likely use rt_event_control with RT_IPC_CMD_RESET for clearing events, or the return value should be handled.

Suggested change

rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);

rt_event_control(&client->event, RT_IPC_CMD_RESET, RT_NULL);

Copilot · 2025-08-16T04:08:39Z

components/net/at/src/at_client.c

    while (size)
    {
        rt_size_t read_len;

-        rt_sem_control(client->rx_notice, RT_IPC_CMD_RESET, RT_NULL);
+        rt_event_recv(&client->event, at_client_rx_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);


This rt_event_recv call with timeout 0 appears to be used for clearing events, but the return value is not checked. This should likely use rt_event_control with RT_IPC_CMD_RESET for clearing events, or the return value should be handled.

Suggested change

rt_event_recv(&client->event, at_client_rx_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);

rt_event_control(&client->event, RT_IPC_CMD_RESET, RT_NULL);

Copilot · 2025-08-16T04:08:39Z

components/net/at/src/at_client.c

        {
-            is_full = RT_TRUE;
+            rt_event_send(&client->event, at_client_deInit_over_event);
+            rt_thread_delete(rt_thread_self());


Calling rt_thread_delete(rt_thread_self()) is dangerous and can lead to undefined behavior. The thread should exit gracefully by returning from the thread function instead of deleting itself.

Suggested change

rt_thread_delete(rt_thread_self());

return -RT_ERROR; /* Exit the thread gracefully */

Rbb666 · 2025-08-16T23:19:50Z

CI错误都是at_device软件包的报错，合并此PR后会对at_device提PR

麻烦先提个 pr 吧，然后引用下

Ryan-CW-Code · 2025-08-17T10:50:52Z

已提交，有改动的地方是互斥锁不再使用rt_mutex_t而是用struct rt_mutex。
主要目的是减少内存分配次数降低内存占用，也减少错误边界判断次数

github-actions bot added component: net Component component: net/at labels Aug 11, 2025

Ryan-CW-Code closed this Aug 11, 2025

Ryan-CW-Code reopened this Aug 11, 2025

Rbb666 requested a review from Copilot August 11, 2025 12:08

This comment was marked as outdated.

Sign in to view

Rbb666 reviewed Aug 12, 2025

View reviewed changes

Ryan-CW-Code closed this Aug 12, 2025

Ryan-CW-Code force-pushed the at_client branch from 7ca2c6b to dce06ba Compare August 12, 2025 05:14

[component][net][at] at_client增加deInit接口

a822d6d

Ryan-CW-Code reopened this Aug 12, 2025

[component][net][at] at_client优化serial_v2适配

fddd89f

Rbb666 requested a review from Copilot August 16, 2025 04:07

Copilot AI reviewed Aug 16, 2025

View reviewed changes

Rbb666 closed this Aug 16, 2025

Rbb666 reopened this Aug 16, 2025

Ryan-CW-Code mentioned this pull request Aug 17, 2025

[at] 适配主线at_client RT-Thread-packages/at_device#218

Merged

Rbb666 closed this Aug 18, 2025

Rbb666 reopened this Aug 18, 2025

-    rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND | RT_EVENT_FLAG_CLEAR, 0, NULL);
+    if (rt_event_control(&client->event, RT_IPC_CMD_RESET, RT_NULL) != RT_EOK)
+    {
+        LOG_E("Failed to clear client event before sending command!");
+        rt_mutex_release(&client->lock);
+        return -RT_ERROR;
+    }

	rt_event_recv(&client->event, at_client_resp_notice_event, RT_EVENT_FLAG_AND \| RT_EVENT_FLAG_CLEAR, 0, NULL);
	rt_event_control(&client->event, RT_IPC_CMD_RESET, RT_NULL);

	rt_thread_delete(rt_thread_self());
	return -RT_ERROR; /* Exit the thread gracefully */

[component][net][at] at_client增加deInit接口 #10598

Are you sure you want to change the base?

[component][net][at] at_client增加deInit接口 #10598

Conversation

Ryan-CW-Code commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: components

🏷️ Tag: components_net_at

📊 Current Review Status (Last Updated: 2025-08-18 22:58 CST)

📝 Review Instructions

Uh oh!

Ryan-CW-Code commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ryan-CW-Code commented Aug 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Ryan-CW-Code commented Aug 11, 2025

Uh oh!

Rbb666 commented Aug 11, 2025

Uh oh!

Rbb666 Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Ryan-CW-Code Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Rbb666 Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Rbb666 Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Ryan-CW-Code commented Aug 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Rbb666 commented Aug 16, 2025

Uh oh!

Ryan-CW-Code commented Aug 17, 2025

Uh oh!

Uh oh!

Ryan-CW-Code commented Aug 11, 2025 •

edited

Loading

github-actions bot commented Aug 11, 2025 •

edited

Loading

Ryan-CW-Code commented Aug 11, 2025 •

edited

Loading