Fix noded topology cache invalidation #5148
Merged
+23
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache is moved to `ZoneView` to better match the 1.15 and earlier cache. The cache is now cleared on `TokensChanged` events as well as `TopologyChanged`, as it was before.
kwvanderlinde
deleted the
bugfix/5137-facing-token-mask-cache-not-invalidated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5137
Description of the Change
The noded topology cache is moved to
ZoneViewto better match the 1.15.2 and earlier cache. The cache is now cleared onTokensChangedevents as well asTopologyChanged, as it was done on 1.15.2.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is