This repository was archived by the owner on Sep 21, 2019. It is now read-only.
Changes for hip-clang for building Caffe2 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #11 |
|
@dagamayank could we get somebody to look at this and, unlike my #11 do something about it? If not, I will review and merge if necessary as this is for PyTorch... |
iotamudelta
approved these changes
Sep 7, 2018
| @@ -596,7 +599,6 @@ struct DipatchHistogram | |||
| return CubDebug(hipErrorNotInitialized); | |||
|
|
|||
| #else | |||
|
|
|||
|
@iotamudelta we can merge this now. can you confirm if the branch it is going into is right? |
|
@dagamayank that is the default branch, yes. So it should be correct, as that's, e.g., what we are pulling for PyTorch. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.