Skip to content
This repository was archived by the owner on Sep 21, 2019. It is now read-only.

Changes for hip-clang for building Caffe2 #13

Conversation

yxsamliu
Copy link
Contributor

@yxsamliu yxsamliu commented Sep 7, 2018

No description provided.

@iotamudelta
Copy link
Contributor

Fixes #11

@iotamudelta
Copy link
Contributor

@dagamayank could we get somebody to look at this and, unlike my #11 do something about it? If not, I will review and merge if necessary as this is for PyTorch...

Copy link
Contributor

@iotamudelta iotamudelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -596,7 +599,6 @@ struct DipatchHistogram
return CubDebug(hipErrorNotInitialized);

#else

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace change

@dagamayank
Copy link

@iotamudelta we can merge this now. can you confirm if the branch it is going into is right?
hip_port_1.7.4?

@iotamudelta
Copy link
Contributor

@dagamayank that is the default branch, yes. So it should be correct, as that's, e.g., what we are pulling for PyTorch. Merging.

@iotamudelta iotamudelta merged commit d92f12a into ROCmSoftwarePlatform:hip_port_1.7.4 Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants