Skip to content

Conversation

@ZhiweiYan-96
Copy link

@ZhiweiYan-96 ZhiweiYan-96 commented Nov 19, 2025

This PR fix the Deepseek-r1 MXFP4 accuracy issue. It is based on the fix in PR #809, and uses triton mha for MLA.

Purpose

Test Plan

bash evaluation/deepseek_fp4/launch_deepseekr1_fp4_TP.sh

Test Result

  • aiter commit: d0a40f55ca1d552f20f2dd55741e7309c936a9d1 (Branch dev/perf)

  • Eager mode

image
  • FULL_AND_PIECEWISE mode
image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

vllm serve $model_path \
--host localhost \
--port 9000 \
--port 6789 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remain the port number

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@zejunchen-zejun
Copy link

We need rebase the latest origin/dev/perf

--seed 123 2>&1 | tee log.server.log &
--gpu_memory_utilization 0.7 \
--block-size 1 \
--seed 123 2>&1 | tee log.server.log

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add back the &

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ZhiweiYan-96 ZhiweiYan-96 changed the title Change the environment set of DeepSeek-R1 FP4 scripts. [acc fix]Change the environment set of DeepSeek-R1 FP4 scripts. Nov 19, 2025
@ZhiweiYan-96 ZhiweiYan-96 changed the title [acc fix]Change the environment set of DeepSeek-R1 FP4 scripts. [wip][acc fix]Change the environment set of DeepSeek-R1 FP4 scripts. Nov 19, 2025
@zejunchen-zejun
Copy link

Is this PR ok to merge? We plan to merge it today.

Signed-off-by: ZhiweiYan-96 <[email protected]>
@ZhiweiYan-96 ZhiweiYan-96 changed the title [wip][acc fix]Change the environment set of DeepSeek-R1 FP4 scripts. [acc fix]Change the environment set of DeepSeek-R1 FP4 scripts. Nov 20, 2025
@zejunchen-zejun zejunchen-zejun merged commit d73b302 into dev/perf Nov 20, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants