Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Tensor Support - Bitwise NOT, Bitwise AND, Bitwise OR #520

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open

RPP Tensor Support - Bitwise NOT, Bitwise AND, Bitwise OR #520

wants to merge 26 commits into from
+827 −1,791

Conversation

r-abishek
Copy link
Member

  • Add support for Bitwise NOT for U8.
  • Restrict bitwise ops (AND OR NOT) to U8.
  • Rename ops from 'logical' to 'bitwise'.

HazarathKumarM and others added 24 commits September 25, 2024 14:03
@HazarathKumarM
Add Initial implementation of Bitwise NOT in HOST backend
afef346
@HazarathKumarM
Add HIP Implementation for Bitwise Not kernel
d2e0e72
@HazarathKumarM
Add Bitwise NOT implementation for I8, F32 and F16 bitdepths
2e4dfc3
@HazarathKumarM
Fix output issues for float variants
341058c
@HazarathKumarM
code cleanup
b0bbcfc
@HazarathKumarM
Modify aligned Length for pln3-pln3 conversion
4f51430
@HazarathKumarM
Modified the casting style and updated doc images
2c8d47d
@HazarathKumarM
update augmentations maps in test suite
dfc12c2
@HazarathKumarM
Merge remote-tracking branch develop' into hk/bitwise_not
2b0a790
@HazarathKumarM
Changes for converting bitwise or and and into u8 bitdepth
4993635
@HazarathKumarM
Changes for solving build errors
e40ae9e
@HazarathKumarM
bitwise and & or for u8 on HOST
a8f4ca9
@HazarathKumarM
Merge branch 'develop' into hk/bitwise_not
6069c79
@HazarathKumarM
Minor changes to resolve error due to merging
8da30eb
@HazarathKumarM
Merge branch 'develop' into db/opt_bitwise_and_or_u8
d937981
@HazarathKumarM
Limited only support for U8
f9ba87e
@HazarathKumarM
Merge branch 'db/opt_bitwise_and_or_u8' into db/bitwise_operation_u8
e311f43
@HazarathKumarM
Renaming from logical to bitwise
86ebe9c
@HazarathKumarM
Golden output file is added
af6bba4
@HazarathKumarM
Merge branch 'db/opt_bitwise_and_or_u8' into hk/bitwise_not
d07ebd2
@HazarathKumarM
Merge branch 'db/bitwise_operation_u8' into hk/bitwise_not
dc90d17
@HazarathKumarM
Changes based on review comments
e0772ed
@HazarathKumarM
REmoved changes in host_logical_operationss.hpp
6b97581
@r-abishek
Merge pull request #348 from HazarathKumarM/hk/bitwise_not
293101d 
RPP Tensor Support - Bitwise NOT, Fixes for Bitwise AND/OR
@r-abishek r-abishek requested a review from a team as a code owner February 19, 2025 05:39
spolifroni-amd
spolifroni-amd reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be addressed in the changelog? If not, it's fine from a docs point-of-view.

@r-abishek r-abishek mentioned this pull request Feb 20, 2025
Closed
@kiritigowda kiritigowda requested a review from rrawther February 21, 2025 19:43
@kiritigowda kiritigowda self-assigned this Feb 21, 2025
@kiritigowda kiritigowda added enhancement New feature or request ci:precheckin labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolifroni-amd spolifroni-amd spolifroni-amd left review comments

@rrawther rrawther Awaiting requested review from rrawther

@LakshmiKumar23 LakshmiKumar23 Awaiting requested review from LakshmiKumar23

At least 1 approving review is required to merge this pull request.

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-abishek @spolifroni-amd @kiritigowda @HazarathKumarM