fix(lemonade): retry interrupted backend setup - #249
Open
volen-silo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eugene Volen <Eugene.Volen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rocm engines install lemonade --reinstallbefore retryingrocm serve.Why: a transient connection loss during first-time Lemonade backend preparation previously aborted
rocm servewith a generic error, forcing users to discover the manual recovery sequence themselves.Risk: low. The change is limited to the backend-install phase, allows one additional attempt, and exposes its failure fixture only in E2E-enabled builds.
Test plan
cargo xtask e2e -- -n 'Repeated Lemonade preparation failure'cargo test -p rocm-engine-lemonade backend_install_cargo test -p e2e-cucumber --libcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targets -- --skip therock::tests::extracting_the_sdk_archive_removes_itcargo fmt --all -- --checkThe skipped archive test is a pre-existing parallel-suite flake on this host (
tartemporarily missing fromPATH) and passes in isolation.