Skip to content

Cherry-pick to release/rocm-rel-6.4: Refactor rocBLAS documentation #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: release/rocm-rel-6.4
Choose a base branch
from

Conversation

amd-jnovotny
Copy link
Contributor

resolves #___

Summary of proposed changes:

  • Cherry-picks the original docs refactoring PR
  • Removes info about internal logging from the logging documentation

@amd-jnovotny amd-jnovotny added ci:docs-only Skip most non-doc CI for this PR documentation Improvements or additions to documentation labels May 27, 2025
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spot anything that shouldn't be there but as so many changes you may want another review, but up to you

@amd-jnovotny
Copy link
Contributor Author

Sure. We can wait for someone else on your team to take a look. Thanks for the review!

* clarify wording on dev package contents

Co-authored-by: Jeffrey Novotny <[email protected]>

---------

Co-authored-by: Jeffrey Novotny <[email protected]>
(cherry picked from commit cd8933e)
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions looks good

Copy link
Contributor

@amcamd amcamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a quick skim I do not see information that is not for 6.4

* repeat rocm-dev info for build from src, standardize

Co-authored-by: Jeffrey Novotny <[email protected]>
(cherry picked from commit 4e3cc1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Skip most non-doc CI for this PR documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants