Skip to content

Collate all ROCm component include directory for spack build #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

renjithravindrankannath
Copy link

@renjithravindrankannath renjithravindrankannath commented Mar 26, 2025

For Spack builds, each ROCm component will have a separate include directory, so we cannot assume /opt/rocm/include to be the path where all the ROCm component headers will be located.

This PR uses the ROCM_INCLUDE_DIRS CMake variable to collate all the ROCm component include directories set by find_package calls.

Fixes # SWDEV-524001

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 26, 2025

Jenkins build for 7901d8c998ed20f5f0358f351a8a80c28ad93a3b commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Detected error during base docker image building:

#32 12.38 The following packages have unmet dependencies:
#32 12.45  rocm-dev : Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#32 12.45             Depends: rocm-device-libs (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#32 12.45  rocm-utils : Depends: rocminfo (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#32 12.45               Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#32 12.46 E: Unable to correct problems, you have held broken packages.
#32 ERROR: process "/bin/sh -c bash ./install_rocm.sh" did not complete successfully: exit code: 100
------
 > [stage-0 24/50] RUN bash ./install_rocm.sh:
12.38 distribution that some required packages have not yet been created
12.38 or been moved out of Incoming.

@jithunnair-amd
Copy link
Collaborator

@renjithravindrankannath This PR should target one of the release/ or internal_testing branches, not main. But I am not in favor of these changes anyway, because it seems to bring back spaghetti code. Can we explore other ways?

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 28, 2025

Jenkins build for 7901d8c998ed20f5f0358f351a8a80c28ad93a3b commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Detected error during base docker image building:

#31 15.03 The following packages have unmet dependencies:
#31 15.11  rocm-dev : Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 15.11             Depends: rocm-device-libs (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 15.11  rocm-utils : Depends: rocminfo (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 15.11               Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 15.11 E: Unable to correct problems, you have held broken packages.
#31 ERROR: process "/bin/sh -c bash ./install_rocm.sh" did not complete successfully: exit code: 100
------
 > [stage-0 23/61] RUN bash ./install_rocm.sh:
15.03 distribution that some required packages have not yet been created
15.03 or been moved out of Incoming.

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 14, 2025

Jenkins build for 7901d8c998ed20f5f0358f351a8a80c28ad93a3b commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 22, 2025

Jenkins build for e16801444b11115bdaca3255d79884a619a3ba60 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Detected error during base docker image building:

#31 11.29 The following packages have unmet dependencies:
#31 11.36  rocm-dev : Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 11.36             Depends: rocm-device-libs (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 11.36  rocm-utils : Depends: rocminfo (= 1.0.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 11.36               Depends: rocm-cmake (= 0.14.0.60304-76~22.04) but 5.0.0-1 is to be installed
#31 11.36 E: Unable to correct problems, you have held broken packages.
#31 ERROR: process "/bin/sh -c bash ./install_rocm.sh" did not complete successfully: exit code: 100
------
 > [stage-0 23/61] RUN bash ./install_rocm.sh:
11.29 distribution that some required packages have not yet been created
11.29 or been moved out of Incoming.

@jithunnair-amd jithunnair-amd changed the title rocthrust, rocprim, rocrand, hipcub, ck and aotriton include paths Collate all ROCm component include directory for spack build Apr 25, 2025
@jithunnair-amd jithunnair-amd requested review from jeffdaily and removed request for jeffdaily April 25, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants