Skip to content

[Do NOT MERGE] [release/2.5] Enable tf32 testing on test_nn #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/2.5
Choose a base branch
from
Open

[Do NOT MERGE] [release/2.5] Enable tf32 testing on test_nn #1859

wants to merge 1 commit into from

Conversation

jagadish-amd
Copy link

@jagadish-amd jagadish-amd commented Jan 27, 2025 •
edited
Loading

  1. In Context.cpp, for the variable allow_tf32 remove static const variable type to non const variable. This allows us to capture the env variable HIPBLASLT_ALLOW_TF32 changes.
  2. Add ROCm arch support to tf32_is_not_fp32()

@jagadish-amd
[release/2.5] Enable tf32 testing on test_nn
0560f5b 
1. In Context.cpp, for the variable allow_tf32 remove static const
variable type to non const variable. This allows us to capture the
env variable HIPBLASLT_ALLOW_TF32 changes.
2. Add ROCm arch support to tf32_is_not_fp32()

Signed-off-by: Jagadish Krishnamoorthy <[email protected]>
@jagadish-amd jagadish-amd changed the title [release/2.5] Enable tf32 testing on test_nn [Do NOT MERGE] [release/2.5] Enable tf32 testing on test_nn Jan 27, 2025
@jagadish-amd
Copy link
Author

jagadish-amd commented Jan 27, 2025 •
edited
Loading

Some of the tf32 test cases in test_nn are failing due to accuracy error. Resolving it and then will remove the DO NOT MERGE label.

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 29, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 31, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as SUCCESS
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 31, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 31, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 3, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 7, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 12, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 13, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as ABORTED
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 13, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 13, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as ABORTED
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 19, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 19, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 19, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 20, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 21, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 25, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 25, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Feb 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 4, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 4, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 4, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 10, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 13, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 14, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 17, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 17, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 17, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 18, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 18, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 19, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 19, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 21, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 24, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 26, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 27, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 1, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 2, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 10, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 10, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 16, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 21, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 21, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Apr 22, 2025 •
edited
Loading

Jenkins build for 0560f5bc08bd95722b1fed1e8e65124f10c10f27 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jagadish-amd