Skip to content

Commit

Permalink
[llvm-mca] Add a -mattr flag
Browse files Browse the repository at this point in the history
This adds a -mattr flag to llvm-mca, for cases where the -mcpu option does not
contain all optional features.

Differential Revision: https://reviews.llvm.org/D68190


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@373358 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
davemgreen committed Oct 1, 2019
1 parent b821fa8 commit bb1cbfa
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
29 changes: 29 additions & 0 deletions test/tools/llvm-mca/ARM/m4-targetfeatures.s
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
# RUN: llvm-mca -mtriple=arm-none-none-eabi -mcpu=cortex-m4 -mattr=+fp64 -instruction-tables < %s | FileCheck %s

vadd.f32 s0, s2, s2
vadd.f64 d0, d2, d2

# CHECK: Instruction Info:
# CHECK-NEXT: [1]: #uOps
# CHECK-NEXT: [2]: Latency
# CHECK-NEXT: [3]: RThroughput
# CHECK-NEXT: [4]: MayLoad
# CHECK-NEXT: [5]: MayStore
# CHECK-NEXT: [6]: HasSideEffects (U)

# CHECK: [1] [2] [3] [4] [5] [6] Instructions:
# CHECK-NEXT: 1 1 1.00 vadd.f32 s0, s2, s2
# CHECK-NEXT: 1 1 1.00 vadd.f64 d0, d2, d2

# CHECK: Resources:
# CHECK-NEXT: [0] - M4Unit

# CHECK: Resource pressure per iteration:
# CHECK-NEXT: [0]
# CHECK-NEXT: 2.00

# CHECK: Resource pressure by instruction:
# CHECK-NEXT: [0] Instructions:
# CHECK-NEXT: 1.00 vadd.f32 s0, s2, s2
# CHECK-NEXT: 1.00 vadd.f64 d0, d2, d2
7 changes: 6 additions & 1 deletion tools/llvm-mca/llvm-mca.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ static cl::opt<std::string>
cl::desc("Target a specific cpu type (-mcpu=help for details)"),
cl::value_desc("cpu-name"), cl::cat(ToolOptions), cl::init("native"));

static cl::opt<std::string>
MATTR("mattr",
cl::desc("Additional target features."),
cl::cat(ToolOptions));

static cl::opt<int>
OutputAsmVariant("output-asm-variant",
cl::desc("Syntax variant to use for output printing"),
Expand Down Expand Up @@ -322,7 +327,7 @@ int main(int argc, char **argv) {
MCPU = llvm::sys::getHostCPUName();

std::unique_ptr<MCSubtargetInfo> STI(
TheTarget->createMCSubtargetInfo(TripleName, MCPU, /* FeaturesStr */ ""));
TheTarget->createMCSubtargetInfo(TripleName, MCPU, MATTR));
if (!STI->isCPUStringValid(MCPU))
return 1;

Expand Down

0 comments on commit bb1cbfa

Please sign in to comment.