register test_component.yml, but disregarded its data for now - #67
Conversation
…s instead of clobbering
| # `update_status_json`'s skip below) until we decide whether component-level | ||
| # granularity is worth tracking; `test_artifacts.yml`'s own report is still | ||
| # the artifact-level source of truth for the `[platform][arch]` leaf. | ||
| _TEST_COMPONENT_WORKFLOW = "test_component.yml" |
There was a problem hiding this comment.
why not have a list
SKIP_WORKFLOW_LIST
or something like this. might be not limited to test component.
then we could also add there the release-asan for the moment.
could evne put it in the workflow specs as extra param? but might be overkill for the moment
There was a problem hiding this comment.
will keep in mind for the future
| """Matrix-cell variants for fan-out pipelines (pytorch/jax py x ref).""" | ||
| """Matrix-cell variants for fan-out pipelines (pytorch/jax py x ref). | ||
|
|
||
| ROCm's `test_component.yml` shard groups never reach here: they're |
There was a problem hiding this comment.
this comment might go stale quickly
| assert leaf.variants[0].status is Status.success | ||
|
|
||
|
|
||
| def _test_component_run( |
There was a problem hiding this comment.
the other comment: i think a more generic skip mechanism might be better (also for testing)
HereThereBeDragons
left a comment
HereThereBeDragons
left a comment
There was a problem hiding this comment.
please update pr description to talk about the more generic _SKIP_WORKFLOW_NAMES
|
|
||
|
|
||
| def test_skip_workflow_names_are_all_disregarded(tmp_path: Path) -> None: | ||
| # Guards the generic `_SKIP_WORKFLOW_NAMES` mechanism itself, not just the |
There was a problem hiding this comment.
update comment. we dont need the history. just what the function does
![quartz-sync[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
2 participants
Motivation
test_artifacts.ymlnow fans out onetest_component.ymlcall per ROCm test component. Sincetest_component.ymlwas never registered inWORKFLOW_SPECS, every one of its completions crashed classification.closes #69
Technical Details
therock_types.py: registertest_component.ymlinWORKFLOW_SPECS(pipeline_type="rocm",pipeline_phase="test",platform_from_test_runs_on=True) soderive_platform_and_pipelineno longer raises.therock_update_status_json.py: add an explicit skip fortest_component.ymlcompletions inupdate_status_json, alongside the existingnative_packagestest skip. These per-component completions are disregarded entirely for now -- nothing is written tostatus.jsonfor them.therock_status_document.py: renamed_merge_matrix_build_leaf->_merge_variant_leaf(now used only by the pytorch/jax build-phase matrix-cell merge) and tightened its guard so a later variant-less build completion can't discard matrix cells already accumulated from an earlier one.Test Plan
scripts/receive_therock/tests/suite locally (pytest).therock_update_status_json_test.py:therock_status_document_test.py(test_upsert_build_variant_less_completion_preserves_variants) covering the tightened variant-preservation guard.Test Result
pytest scripts/receive_therock/tests/-> 403 passed, 4 failed (all four pre-existing and unrelated to this change)Submission Checklist