shell/saul: Rename internal functions #21416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Impact: minor
benpicco
approved these changes
Apr 16, 2025
Probably because somehow this got included: https://man7.org/linux/man-pages/man2/read.2.html I think it is indeed good practice to not use standard POSIX function names in your C base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🐶,
this renames internal functions of the shell command module
saul_reg.As C does not have proper name spacing, reusing names is risky. Especially well known names such as
readandwrite.I am not sure how I triggered the issue for me, as the functions are static but well...
Testing procedure
If the CI doesn't find anything and we get a regression, then there is a coverage hole in our tests :>
Otherwise: build & flash the default example and use saul I guess.
Issues/PRs references