Feat/pypi stats #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
hechth
approved these changes
Feb 11, 2025
| pip install -r requirements.txt | ||
| - name: execute py script | ||
| env: | ||
| github_token: '${{ secrets.github_token }}' |
There was a problem hiding this comment.
need to create and add the correct token
|
|
||
| ### Project setup | ||
| It is assumed you can clone and change directories into the development repo. | ||
| Create a virtualenv or conda environment (whatever your poison) |
There was a problem hiding this comment.
Suggested change
| Create a virtualenv or conda environment (whatever your poison) | |
| Create a virtualenv or conda environment (whatever your poison). |
| It is assumed you can clone and change directories into the development repo. | ||
| Create a virtualenv or conda environment (whatever your poison) | ||
|
|
||
| Once in the repos directory, activate your env then run the following command to install th needed python libraries. |
There was a problem hiding this comment.
Suggested change
| Once in the repos directory, activate your env then run the following command to install th needed python libraries. | |
| Once in the repos directory, activate your env then run the following command to install the needed python libraries. |
|
|
||
| 1: Do not push local development changes from `tmp` folder and `reports` folder. In fact do not edit them at all !!! | ||
|
|
||
| 2: When testing with `act` do not use a token that has the permission to make push requests else your test data wil mess with "production" data |
There was a problem hiding this comment.
Suggested change
| 2: When testing with `act` do not use a token that has the permission to make push requests else your test data wil mess with "production" data | |
| 2: When testing with `act` do not use a token that has the permission to make push requests else your test data will mess with "production" data. |
|
|
||
| 2: When testing with `act` do not use a token that has the permission to make push requests else your test data wil mess with "production" data | ||
|
|
||
| 3: When testing with `act` know that the push may fail due to the fact that you can't directly push to main |
There was a problem hiding this comment.
Suggested change
| 3: When testing with `act` know that the push may fail due to the fact that you can't directly push to main | |
| 3: When testing with `act` know that the push may fail due to the fact that you can't directly push to main. |
|
|
||
| 3: When testing with `act` know that the push may fail due to the fact that you can't directly push to main | ||
|
|
||
| 4: Always,I repeat always devlop on another branch not main and never push directly to main. |
There was a problem hiding this comment.
Suggested change
| 4: Always,I repeat always devlop on another branch not main and never push directly to main. | |
| 4: Always, I repeat always devlop on another branch not main and never push directly to main. |
| source = sanitize_filename_component(source) | ||
| action = sanitize_filename_component(action) | ||
| seperator = "__" | ||
| return f"{folder}/{project}{seperator}{package}{seperator}{source}{seperator}{action}{seperator}{date_part}.{extension}" |
There was a problem hiding this comment.
how about separator.join(...)? Might be tiny bit easier to read?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented the base code needed to fetch repo stats from GitHub and Pypi
Issue ticket number and link
Checklist before requesting a review