Returning a count from addN (#833) #834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernhees
reviewed
Oct 28, 2018
rdflib/graph.py
Outdated
| import warnings | ||
|
|
||
| from hashlib import md5 | ||
|
|
Member
There was a problem hiding this comment.
please keep commits concise, don't change random other things...
Contributor
Author
There was a problem hiding this comment.
Fair enough. They are unused though.
| ) | ||
| if triples_stored is None: | ||
| return -1 | ||
| return triples_stored |
Member
There was a problem hiding this comment.
hmm, this won't really work without also at least updating the store interface in store.py
also i'd prefer a simple return in front of the dispatch to store... i don't see how -1 is better than simply returning None
Contributor
Author
There was a problem hiding this comment.
You're correct. I don't actually recall why I went with -1.
The intention is to make it optional. I have added a flag member variable to indicate whether addN returns a count on a store I maintain, but I didn't see a reason to make it official interface.
joernhees
added
enhancement
Member
|
Open/Close Travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.