Fix crashing when reading audio samples with wide characters #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
NachosChipeados
approved these changes
Mar 15, 2025
ASpoonPlaysGames
removed
the
needs testing
Alystrasz
approved these changes
Mar 17, 2025
Alystrasz
added
READY TO MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #840
Test using https://thunderstore.io/package/download/Xiaobbuguai/BlueArchivesBeautificationPack/1.1.0/ (the updated version fixed the crashing by renaming the files) and booting the game to the main menu. Might also be worth testing that the audio overrides still work as
badly asbefore.The external console (and possible also the in-game console) will likely log these incorrectly, as they are wide chars but our logging eventually goes through to WriteConsoleA which doesn't support wide chars. Fixing this would take a bit more effort and is out of scope here.
Previous fixes for wide file paths didn't log through spdlog or anything, so they didn't end up needing to enable
SPDLOG_WCHAR_TO_UTF8_SUPPORT