-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper basic map making guide #196
base: main
Are you sure you want to change the base?
Conversation
hey, did you figure out how to run it locally? the RST format was my idea, as its relatively extensible. its the reason we can have squirrel syntax highlighting, for example. but i never ended up adding proper language support, so its a bit... underused. i hope it was easy enough to figure out tho? |
i didn't lol i just let it auto build with the checks looks like i did mess up the image i added but will have to fix later |
3 weeks later i come back and try something random and it works, sounds about right ill go through and add proper images now then set to ready for review |
images added properly, enjoy 400+ diff and me being an idiot with commits :D |
@itscynxx is this done frfr? |
it's pretty close at least, might just want someone to run through it another time with a fresh install to make sure the paths in the beginning are correct i can check later too, but it'll be at least like 6 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No broken links or anything. I just want a link replaced.
|
||
.. youtube:: zgWDme7Y6oI | ||
|
||
Sample map: https://cdn.discordapp.com/attachments/925435799057604709/1041813222547791953/corner_test_map.map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discord cdn links expire now. I have it available on my server if nobody has anything against that
Sample map: https://cdn.discordapp.com/attachments/925435799057604709/1041813222547791953/corner_test_map.map | |
`Sample map <https://salzgrube.club/static/northstar/corner_example.map>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems with that personally, but github's cdn may be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the file in the repo might be a better idea then, I wouldn't bet on github's cdn keeping everything forever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the update on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk flip a coin or smth
I finally got around to doing this, I did in fact have the resources directory wrong (I had installed them like 3 times on my local folder and they were all combined and messed up) I updated that bit |
We might wanna recreate this PR against the new docs over at https://github.com/R2Northstar/NorthstarDocs/ ^^ |
I've never made a pr in this repo but this is probably right maybe
I still need to add some images that aren't here yet but I wanted to get this opened for reviews because i imagine this will take a decent while to get merged, so just note that more images will be added in spots where it says there'll be one but there isn't
Fun fact I also don't know this doc file format! I probably messed a lot up because of this but I only knew that a
.rst
file existed about 10 minutes before I started writing so uh good luck explaining my stupidity back to meAlso not entirely sure how to display images so hopefully someone can confirm or deny if the image docs I followed are horribly wrong or passable
To preview this PR use https://r2northstar--196.org.readthedocs.build/en/196/