-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner config.lua #19
Conversation
Use uv.hrtime(): Replaced vim.fn.reltime() with uv.hrtime() for better precision. Replace vim.fn.split with vim.split Utilized uv.fs_stat to check if a path is a directory and uv.fs_realpath to resolve symlinks. Replaced vim.fn.executable with uv.fs_access for checking executable permissions.
Github doesn't allow the merge due to selene finding errors. |
I checked your branch out. It has loop errors. This means that module X requires module Y, which requires module X. I'm fixing this kind of issue by requiring module Y inside the function that uses it, not at the top of module X. |
Could you move the line |
I'll soon finish my work shift and be on it (Can it be done from Github mobile?). Maybe I should just revert the second commit where I define |
I never used Github mobile, but there is no hurry.
I think this would be enough for now.
Yes, at some point we may think about moving functions to more appropriate modules. Other tasks are:
|
It seems tha |
As far as I know, Lua doesn't support patterns with I will fix these issues in the next commit. |
No description provided.