Skip to content

fix: ssg on windows #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 25, 2025
Merged

fix: ssg on windows #8072

merged 8 commits into from
Oct 25, 2025
+123 −93

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Oct 18, 2025

No description provided.

@Varixo Varixo self-assigned this Oct 18, 2025
@Varixo Varixo requested a review from a team as a code owner October 18, 2025 20:29
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 47a3b9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo linked an issue Oct 18, 2025 that may be closed by this pull request
[🐞] npm run build.server not working as expected #8031
Open
@Varixo Varixo marked this pull request as draft October 18, 2025 20:39
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 18, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8072

npm i https://pkg.pr.new/@builder.io/qwik-city@8072

npm i https://pkg.pr.new/eslint-plugin-qwik@8072

npm i https://pkg.pr.new/create-qwik@8072

commit: 47a3b9f

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 47a3b9f

gioboa
gioboa previously approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

wmertens
wmertens approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens marked this pull request as ready for review October 25, 2025 12:45
@wmertens wmertens merged commit 6e866a0 into main Oct 25, 2025
23 checks passed
@wmertens wmertens deleted the fix-ssg-windows branch October 25, 2025 12:45
@github-project-automation github-project-automation bot moved this from Backlog to Done in Qwik Development Oct 25, 2025
@Varixo Varixo mentioned this pull request Oct 25, 2025
Merged
gioboa
gioboa reviewed Oct 25, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this useful fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gioboa gioboa gioboa left review comments

@wmertens wmertens wmertens approved these changes

Assignees

@wmertens wmertens

@Varixo Varixo

Labels

None yet

Projects

Qwik Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐞] npm run build.server not working as expected

4 participants

@Varixo @wmertens @gioboa