Skip to content

feat: enhance locale handling with AsyncLocalStorage support for server-side requests #7826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: build/v2
Choose a base branch
from
Open

feat: enhance locale handling with AsyncLocalStorage support for server-side requests #7826

wants to merge 6 commits into from
+65 −5

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Aug 15, 2025 •
edited
Loading

feat: enhance locale handling with AsyncLocalStorage support for server-side requests

#7806

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1c341e4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 changed the title feat: enhance locale handling with AsyncLocalStorage support for serv… feat: enhance locale handling with AsyncLocalStorage support for server-side requests Aug 15, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 15, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7826

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7826

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7826

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7826

commit: 1c341e4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 15, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1c341e4

@JerryWu1234 JerryWu1234 self-assigned this Aug 15, 2025
@JerryWu1234 JerryWu1234 marked this pull request as ready for review August 15, 2025 09:37
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner August 15, 2025 09:37
@JerryWu1234
Copy link
Contributor Author

@wmertens does it need a test?.

wmertens
wmertens requested changes Aug 15, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start but I think Core should not be influenced by Router.

wmertens
wmertens requested changes Aug 16, 2025
View reviewed changes
wmertens
wmertens requested changes Aug 18, 2025
View reviewed changes
@JerryWu1234
Copy link
Contributor Author

@wmertens done .please check it again , thanks

@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens requested changes

Assignees

@JerryWu1234 JerryWu1234

Labels
None yet
Projects
Qwik Development
Status: Waiting For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JerryWu1234 @wmertens