-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: update all deps minor #7529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm trying this just to make sure there are no breaking changes similar to #7528 |
@wmertens I'm stuck, can you guide me where to look. |
@sreeisalso looks like a require() call snuck into esm code. Try to figure out where it happens (open the files in the stack trace) and maybe you'll have to downgrade some deps. See https://dev.to/marcogrcr/nodejs-and-esbuild-beware-of-mixing-cjs-and-esm-493n for some similarities. |
commit: |
This reverts commit f725296.
yes, yaml 2.7.0 and above causing this issue, thanks for the help |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@sreeisalso it has merge conflicts now. Can you fix? I'll merge this after we release 1.14 |
@wmertens resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your commitment @sreeisalso
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help @sreeisalso
is this PR still valid?
@gioboa I don't know how to fix the failing unit test, apart from updating the hard coded values. |
Let me check. Btw thanks for your commitment @sreeisalso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aligned the failing test, a dependency is changing the js content, probably terser.
I added few questions, Thanks
What is it?
Description
updated all deps minor to latest
Checklist
pnpm change