-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): expose the search in the small viewport #6966
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. Can't you reuse the search icon from the desktop view?
Added the icon back and made it possible to control the Modal from An external controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really good to me, some small things left!
commit: |
@Kampouse you added 250 commits from somewhere and now your PR has 440 changed files 😬 If you have a Mac I recommend using https://gitup.co to fix this, otherwise see if you can cherry pick your own commits on a fresh branch? |
90ff5b9
to
3ad33f8
Compare
Alright this is much better did not know about cherry-pick thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁🐕
What is it?
Description
I was able to achieve decent behavior by utilizing the QwikUI modal component. The current implementation resulted in the component being partially hidden (off-screen) above pictue. Additionally, the implementation is missing a proper search button icon

I'm sharing this here to gather feedback on my progress so far.
Related issue: #6949
Please feel free to review and provide any suggestions or improvements.
Checklist:
pnpm change
and documented my changes