Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to disable "end on process signal" handlers #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow to disable "end on process signal" handlers #379

wants to merge 1 commit into from

Conversation

Cactusbone
Copy link

Implements #280

Acceptance Checklist

  • Story: Code is focused on the linked stories and solves a problem
  • One of:
    • For Features: New unit tests are added covering the new functions or modifications => I'm not sure how to test it
  • Code Documentation changes are included for public interfaces and important / complex additions
  • External Documentation is included for API changes, or other external facing interfaces

Review Checklist

  • The code does not duplicate existing functionality that exists elsewhere
  • The code has been linted and follows team practices and style guidelines
  • The changes in the PR are relevant to the title
    • changes not related should be moved to a different PR
  • All errors or error handling is actionable, and informs the viewer on how to correct it

@Cactusbone Cactusbone requested a review from a team as a code owner October 9, 2024 16:35
iamart
iamart previously approved these changes Oct 9, 2024
View reviewed changes
Xjph
Xjph previously approved these changes Oct 9, 2024
View reviewed changes
Cactusbone
Cactusbone commented Oct 11, 2024
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
@Cactusbone Cactusbone dismissed stale reviews from Xjph and iamart via 8c48fe0 October 11, 2024 16:38
@Cactusbone Cactusbone force-pushed the end-on-process-signal branch from 4d05321 to 8c48fe0 Compare October 11, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamart iamart iamart approved these changes

@Xjph Xjph Xjph left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cactusbone @Xjph @iamart