Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make _resolvePath available in types #365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kr0san89
Copy link

@Kr0san89 Kr0san89 commented Jan 23, 2024

The PR adds _resolvePath as protected in the typings so when extending the Filesystem class can be used

Acceptance Checklist

  • Story: Code is focused on the linked stories and solves a problem
  • One of:
    • For Bugs: A unit test is added or an existing one modified
    • For Features: New unit tests are added covering the new functions or modifications
  • Code Documentation changes are included for public interfaces and important / complex additions
  • External Documentation is included for API changes, or other external facing interfaces

Review Checklist

  • The code does not duplicate existing functionality that exists elsewhere
  • The code has been linted and follows team practices and style guidelines
  • The changes in the PR are relevant to the title
    • changes not related should be moved to a different PR
  • All errors or error handling is actionable, and informs the viewer on how to correct it

@Kr0san89 Kr0san89 requested a review from a team as a code owner January 23, 2024 14:36
@Kr0san89
Copy link
Author

Kr0san89 commented Nov 6, 2024

@iamart can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant