Update to 1.20.4 #92
Merged
Update to 1.20.4 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschr15
approved these changes
Mar 31, 2024
|
built, game runs (tested on local machine) |
|
Last minute question, should this be 4.0.0? Only one method was removed due to the update. |
|
My main issue with raising the major version is that it will give the impression that the API had major breaking changes. However, this is due to Minecraft, not the API itself. |
|
Btw I bumped the major since the API surface had a breaking change, this is kind of just an issue with modding minecraft, each minor and likely patch versions will cause breakage. I guess this can be thought more as "should mods be using semver when Minecraft doesn't" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.