-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.20.2 #88
Update to 1.20.2 #88
Conversation
I'll try and recap the other messages I sent, but I didn't save them like the original:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just want a quick confirmation that it can be merged as well as that the codec changes didn't accidentally break things, as that looks like it's probably the most fragile
I was unaware of any Codec changes tbh, I assume any tests would have ran and passed, Codecs otherwise aren't in my area of expertise, if there's any notable mod I can test with real quick I'll give that a shot. |
Seems to be IntellijJank but I'm unsure how to run these existing Codec tests. |
Managed to hack something together to run the Codec serialization tests and they all pass.
|
Sorry for having this deleted before, original PR message below: