Skip to content

Fix navigation to method calls within lambdas and static initializers #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: develop/2.7
Choose a base branch
from
Open

Fix navigation to method calls within lambdas and static initializers #308

wants to merge 14 commits into from

Conversation

PiTheGuy
Copy link
Contributor

@PiTheGuy PiTheGuy commented Sep 28, 2025 •
edited by supersaiyansubtlety
Loading

Fixes #311

This PR uses a Java parsing library to parse the source code to obtain ranges. This means it would add an additional dependency, but this seems like the better option compared to the alternative of parsing it manually.

@PiTheGuy PiTheGuy marked this pull request as draft September 28, 2025 22:09
@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend labels Sep 29, 2025
@PiTheGuy PiTheGuy changed the title Fix navigation to method calls within static initializers Fix navigation to method calls within lambdas and static initializers Sep 29, 2025
@PiTheGuy PiTheGuy changed the base branch from master to develop/2.7 September 29, 2025 22:31
@PiTheGuy PiTheGuy marked this pull request as ready for review September 29, 2025 22:56
@PiTheGuy
Copy link
Contributor Author

Ready

supersaiyansubtlety
supersaiyansubtlety requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work as expected here:
java_3gNZFWzbX2

  • the b.b()V call doesn't navigate; it should got to the runnable lambda
  • the b.<clinit>()V call navigates to the runnable lambda; it should go to the static init call
  • the b.<init>()V call works correctly

supersaiyansubtlety added a commit to supersaiyansubtlety/enigma that referenced this pull request Oct 1, 2025
@supersaiyansubtlety
add javaparser dep matching QuiltMC#308
6568255
@supersaiyansubtlety supersaiyansubtlety linked an issue Oct 1, 2025 that may be closed by this pull request
Navigating to method calls within lambdas using VineFlower #311
Open
@supersaiyansubtlety
Copy link
Member

This fixes the issue for VineFlower but not Procyon; I've created sub-issues.

@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Oct 3, 2025
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersaiyansubtlety supersaiyansubtlety supersaiyansubtlety approved these changes

Assignees
No one assigned
Labels
backend affects the enigma backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigating to method calls within lambdas using VineFlower Navigating to method calls within lambdas doesn't work correctly
3 participants
@PiTheGuy @supersaiyansubtlety @ix0rai