Fix 256 #305
Open
Fix 256 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix QuiltMC#256 - also fixes an issue where an entry could be in a navigator panel multiple times under the same TokenType
…der when their types were updated
supersaiyansubtlety
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256 by re-setting
NavigatorPanel's entries instead of re-adding them inEditorPanel::setSource.NavigatorPanelgets refreshed twice when mapping are reloaded: once before mappings are loaded and once after.Before, when entries were re-added, they'd be skipped if they were already contained by the navigator; since the navigator contained the entries after the un-mapped refresh, they wouldn't be added for the mapped refresh.
The old conditional adding could also result in an entry being in the navigator multiple times due to type changes.
Also:
"00/0"because it just ensured the index had at least two digits"0/0"and"01/23"which ensures fixed length