Skip to content

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Sep 14, 2025

Fixes #201

IdentifierPanel::refreshReference passed deobf LocalVariableEntrys to EntryIndex which only contains obf entries.

This fixes that and:

  • gets the param descriptor from EntryIndex instead of deriving it from the parent method
  • eliminates the possibility of incorrect types in the IdentifierPanel due to index offsets
  • shows <unknown> for the types of un-indexed locals (this should only happen for non-args)

Based on #282 because it adds param indexing. rebased

Ready once #282 is merged. ready

@supersaiyansubtlety supersaiyansubtlety self-assigned this Sep 14, 2025
@supersaiyansubtlety supersaiyansubtlety added bug Something isn't working user interface affects the enigma ui labels Sep 14, 2025
@supersaiyansubtlety supersaiyansubtlety force-pushed the fix-201 branch 2 times, most recently from e4aabdb to 53bfdbc Compare September 26, 2025 20:16
@supersaiyansubtlety
Copy link
Member Author

ready!

Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely! kinda embarrassing how i never noticed that this was the fix. thanks for squashing this bug!

@ix0rai ix0rai merged commit 769ef0d into QuiltMC:develop/2.7 Oct 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user interface affects the enigma ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants