Skip to content

Fix triggering of single/double tap action when performing system navigation gesture #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

equeim
Copy link
Contributor

@equeim equeim commented Aug 22, 2024

Screen recording of issue that this patch fixes:

Screen_Recording_20240822_222226_RedReader.mp4

…igation gesture

In that case we receive ACTION_CANCEL event and don't want to trigger tap actions.
@equeim equeim force-pushed the fix-system-gestures-in-image branch from 5a26d12 to 145ab7f Compare August 22, 2024 20:26
@equeim
Copy link
Contributor Author

equeim commented Aug 25, 2024

Also discovered another issue when swipe overlay (when viewing image from a gallery) can get stuck when doing a very short swipe. The reason is that mCurrentTouchState may not be changed to ONE_FINGER_DRAG due to condition here:

, but because of fallthrough the onHorizontalSwipe listener is called anyway causing the overlay to show. However onHorizontalSwipeEnd listener that hides the the overlay is called only if state is ONE_FINGER_DRAG: , which means it won't be called in this case.

Not sure how to fix this properly without making this code even messier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants